perf(storage_mapping): Use oc_filecache.path_hash which is covered by an index#683
Open
provokateurin wants to merge 1 commit intomainfrom
Open
perf(storage_mapping): Use oc_filecache.path_hash which is covered by an index#683provokateurin wants to merge 1 commit intomainfrom
provokateurin wants to merge 1 commit intomainfrom
Conversation
provokateurin
requested review from
icewind1991 and
max-nextcloud
as code owners
provokateurin
force-pushed
the
perf/storage-mapping/path-hash
branch
2 times, most recently
from
ac62dd6 to
21c214b
Compare
icewind1991
force-pushed
the
perf/storage-mapping/path-hash
branch
from
21c214b to
1ef0d2e
Compare
… an index Signed-off-by: provokateurin <kate@provokateurin.de>
icewind1991
force-pushed
the
perf/storage-mapping/path-hash
branch
from
1ef0d2e to
08c11c0
Compare
Member
Author
|
Why did you revert the flake changes? I was not able to get a devshell without icewind1991/cross-naersk#1 (even without updating anything else). |
Member
Author
|
So the index doesn't matter, but this is still an improvement due to requiring less data being selected (path vs. path_hash width). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on icewind1991/cross-naersk#1
On PostgreSQL no index exists for
oc_filecache.pathand on all other DBs it is only a partial index: https://github.com/nextcloud/server/blob/b729dc4eadfe78d6d5c41775378a04b8d4177482/core/Migrations/Version13000Date20170718121200.php#L244-L244With enough users on the instance, this query can become very slow, especially on PostgreSQL.