Repository navigation
fix(deps): keep the app's brick/math within the range core's packages allow - #189
Merged
Merged
Conversation
oleksandr-nc
force-pushed
the
fix/brick-math-core-range
branch
2 times, most recently
from
November 9, 2026 17:34
daf1330 to
05a6bd4
Compare
oleksandr-nc
changed the title
oleksandr-nc
force-pushed
the
fix/brick-math-core-range
branch
3 times, most recently
from
November 9, 2026 18:11
7659e7b to
f8fe09d
Compare
… allow The app's Composer autoloader registers itself in front of Nextcloud's own, so for every class that is not loaded yet, the app's copy is the one the whole process gets. The app ships brick/math through ramsey/uuid: 0.18.0 in the released 3.5.2 and 3.6.0, 1.0.0 on main. All released versions of Nextcloud 33, 34 and 35, and master, ship brick/math 0.12.1 for spomky-labs/cbor-php, spomky-labs/pki-framework and web-auth/cose-lib, which allow it up to 0.12 only. With the app enabled they run against the app's copy, which no longer has BigInteger::testBit() (removed in 0.15.0, along with other breaking changes), so pki-framework's Real::fromFloat() fails with "Call to undefined method Brick\Math\BigInteger::testBit()". ramsey/uuid accepts brick/math ^0.12 as well, so requiring ^0.12 keeps the app's copy inside the range core's packages allow. The lock moves brick/math from 1.0.0 to 0.12.3; no other package changes. Dependabot ignores brick/math 0.13 and later from now on: it rewrites the constraint of a direct requirement when it bumps it, as it did for kiota-http-guzzle in #115. Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
oleksandr-nc
force-pushed
the
fix/brick-math-core-range
branch
from
November 9, 2026 18:45
f8fe09d to
d772b0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app's Composer autoloader registers itself in front of Nextcloud's own, so for every class that is not loaded yet, the app's copy is the one the whole process gets. The app ships brick/math through ramsey/uuid: 0.18.0 in the released 3.5.2 and 3.6.0, 1.0.0 on main. All released versions of Nextcloud 33, 34 and 35, and master, ship brick/math 0.12.1 for spomky-labs/cbor-php, spomky-labs/pki-framework and web-auth/cose-lib, which allow it up to 0.12 only. With the app enabled they run against the app's copy, which no longer has
BigInteger::testBit()(removed in 0.15.0, along with other breaking changes), so pki-framework'sReal::fromFloat()fails with Call to undefined method Brick\Math\BigInteger::testBit().ramsey/uuid accepts brick/math
^0.12as well, socomposer.jsonnow requires^0.12, which keeps the app's copy inside the range core's packages allow. The lock moves brick/math from 1.0.0 to 0.12.3; no other package changes. Dependabot ignores brick/math 0.13 and later from now on: it rewrites the constraint of a direct requirement when it bumps it, as it did for kiota-http-guzzle in #115.🤖 AI (if applicable)