Skip to content

fix: avoid vsprintf ValueError in non-English notification locales #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oleksandr-nc merged 1 commit into from
May 26, 2026
Merged

fix: avoid vsprintf ValueError in non-English notification locales #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Fixed

- Stop spamming the log with `\InvalidArgumentException` deprecation warnings from the notifier; throw `OCP\Notification\UnknownNotificationException` instead for unknown notifications.
- Fix `ValueError` from `vsprintf()` that broke notifications for non-English users.

## 1.4.1 - 2025-11-10

Expand Down
2 changes: 1 addition & 1 deletion lib/Notification/Notifier.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public function prepare(INotification $notification, string $languageCode): INot
case 'new_open_tickets':
$p = $notification->getSubjectParameters();
$nbOpen = (int)($p['nbOpen'] ?? 0);
$content = $l->n('You have %s open issue with recent activity in Jira.', 'You have %s open issues with recent activity in Jira.', $nbOpen, [$nbOpen]);
$content = $l->n('You have %n open issue with recent activity in Jira.', 'You have %n open issues with recent activity in Jira.', $nbOpen);

//$theme = $this->config->getUserValue($userId, 'accessibility', 'theme', '');
//$iconUrl = ($theme === 'dark')
Expand Down
Loading