"Edit locally" in Web → Reveal in Finder on macOS#10303
Merged
Conversation
Signed-off-by: Rello <github@scherello.de>
Rello
requested review from
camilasan,
i2h3,
mgallien and
nilsding
as code owners
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10303.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
8 tasks
i2h3
changed the title
i2h3
requested changes
Jul 6, 2026
| #ifndef BUILD_FILE_PROVIDER_MODULE | ||
| // Show the loading dialog but don't show the filename until we have | ||
| // verified the token | ||
| // verified the token. File Provider handles nc:// without a progress dialog. |
Collaborator
There was a problem hiding this comment.
This is a misleading comment which must be removed. The file provider extension does not handle anything at all and the main app is not the file provider. The main app has the custom URL scheme registered locally (an extension cannot do that) and is invoked for handling.
i2h3
approved these changes
Jul 6, 2026
Collaborator
Author
|
/backport to stable-34.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nextcloud/documentation#15268