refactor(pinia): move board logic to boardStore - #8234
Conversation
21e5671 to
6003985
Compare
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
I have some nitpicking code style comments. Other than that, it looks good. Didn't test myself and only eyeballed the code changes.
| title, | ||
| color: this.color.substring(1), | ||
| }) | ||
| await useBoardStore().createBoard({ title, color: this.color.substring(1) }) |
There was a problem hiding this comment.
Is there a particular reason why you don't use mapActions(useBoardStore, ['createBoard']) here? Maybe I'm missing something, but it seems like inconsistent code style to me.
| import CreateNewCardCustomPicker from '../views/CreateNewCardCustomPicker.vue' | ||
| import { getCurrentUser } from '@nextcloud/auth' | ||
| import { mapActions } from 'pinia' | ||
| import { mapActions, mapState as mapStatePinia } from 'pinia' |
There was a problem hiding this comment.
In other places you used the pattern to rename the Vuex version to mapStateVuex which seems cleaner to me as you don't have to rename again once Vuex gets removed.
| this.setFilter({ ...this.filter }) | ||
| }, | ||
| setFilter() { | ||
| setFilterLocal() { |
There was a problem hiding this comment.
If I'm correct, in other places you used the pattern to import the store method as setFilterInStore(), so again you introduce a different code style here.
6003985 to
d6aef13
Compare
Signed-off-by: grnd-alt <git@belakkaf.net>
Signed-off-by: grnd-alt <git@belakkaf.net>
d6aef13 to
58125bf
Compare
2 participants
No description provided.