Skip to content

[stable8.0] fix(SettingsSortContacts): update it to latest NcSelect #4862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
backportbot wants to merge 1 commit into from
Closed

[stable8.0] fix(SettingsSortContacts): update it to latest NcSelect #4862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 17 additions & 12 deletions src/components/AppNavigation/Settings/SettingsSortContacts.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,9 @@
:searchable="false"
:allow-empty="false"
:options="options"
:custom-label="formatSortByLabel"
:get-option-key="(option) => option.key"
:input-label="t('contacts', 'Sort by')"
label="label"
@input="sortContacts" />
@update:model-value="sortContacts" />
</div>
</template>

Expand All @@ -30,33 +29,39 @@ export default {
IconList,
},

data() {
return {
selected: null,
}
},

computed: {
/* Order Keys */
options() {
return [
{
label: t('contacts', 'First name'),
key: 'firstName',
value: 'firstName',
},
{
label: t('contacts', 'Last name'),
key: 'lastName',
value: 'lastName',
},
{
label: t('contacts', 'Phonetic first name'),
key: 'phoneticFirstName',
value: 'phoneticFirstName',
},
{
label: t('contacts', 'Phonetic last name'),
key: 'phoneticLastName',
value: 'phoneticLastName',
},
{
label: t('contacts', 'Display name'),
key: 'displayName',
value: 'displayName',
},
{
label: t('contacts', 'Last modified'),
key: 'rev',
value: 'rev',
},
]
},
Expand All @@ -69,9 +74,9 @@ export default {
},
},
methods: {
sortContacts(orderKey) {
const key = orderKey && orderKey.key ? orderKey.key : 'displayName'
this.$store.commit('setOrder', key)
sortContacts(selected) {
const value = selected && selected.value ? selected.value : 'displayName'
this.$store.commit('setOrder', value)
this.$store.commit('sortContacts')
localStorage.setItem('orderKey', key)
},
Expand Down