allow admins to edit circle details #2190
Conversation
It should be possible for admins to edit it's name, description and display name. Again this would be necessary for Collectives. Signed-off-by: janbaum <jan.baumgarten@tutanota.com>
|
because this request should only be valid from the owner, we might needs to add some check on federated teams. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
It makes sense from my side to be able to do this. In general, I'm not sure whether having a separate "owner" role is necessary in the first place to be honest. At the very least, editing should not be restricted to owners, maybe only the deletion of the circle. We already have a split between Admin/Moderator, that should be enough. |
|
/backport to stable33 |
|
/backport to stable32 |
|
/backport to stable31 |
4 participants
It should be possible for admins to edit it's name, description and display name. Again this would be necessary for Collectives.
The
verify()function is only called for editing those three properties.fixes: #2181