Skip to content

Use clean internal link when server mod_rewrite_working is true#17251

Merged
alperozturk96 merged 7 commits into
nextcloud:masterfrom
MaqsudMallick:ingestModRewriteWorking
Jul 9, 2026
Merged

Use clean internal link when server mod_rewrite_working is true#17251
alperozturk96 merged 7 commits into
nextcloud:masterfrom
MaqsudMallick:ingestModRewriteWorking

Conversation

@MaqsudMallick

@MaqsudMallick MaqsudMallick commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Fixes #13071
Depends on nextcloud/android-library#2057

@MaqsudMallick
fix(sharing): use clean internal link when server mod_rewrite works
496aa48 
Signed-off-by: MaqsudMallick <maqsudmallick@gmail.com>
@MaqsudMallick
point android-library at PR2057 for review
331a488 
Signed-off-by: MaqsudMallick <maqsudmallick@gmail.com>
tobiasKaminsky
tobiasKaminsky requested changes Jul 2, 2026
View reviewed changes
Comment thread app/src/main/java/com/nextcloud/client/database/migrations/Migration100to101.kt Outdated
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

package com.nextcloud.client.database.migrations

@tobiasKaminsky tobiasKaminsky Jul 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be working with auto migration.
Can you please test this?
This would omit the manual migration.

@MaqsudMallick MaqsudMallick Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested with the auto migration. It is working.
Removed the manual migration in favor of auto migration.

@MaqsudMallick
change manual to auto migration for mod_rewrite
ba09e03 
Signed-off-by: MaqsudMallick <maqsudmallick@gmail.com>
@MaqsudMallick MaqsudMallick force-pushed the ingestModRewriteWorking branch from 073c93c to ba09e03 Compare July 2, 2026 18:14
@MaqsudMallick
Merge remote-tracking branch 'origin/master' into ingestModRewriteWor…
239555f 
…king

Signed-off-by: MaqsudMallick <maqsudmallick@gmail.com>
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

alperozturk96
alperozturk96 requested changes Jul 9, 2026
View reviewed changes

@alperozturk96 alperozturk96 left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use latest library version?

https://github.com/nextcloud/android-library/commits/master/

e.g.72a95a990f57135ef2b658d49a99dd193dcd6671

Then we can merge this.

@MaqsudMallick
Merge remote-tracking branch 'origin/master' into ingestModRewriteWor…
0ba6d2a 
…king

Signed-off-by: MaqsudMallick <maqsudmallick@gmail.com>
@MaqsudMallick
update android lib version
090ce74 
Signed-off-by: MaqsudMallick <maqsudmallick@gmail.com>
@MaqsudMallick

MaqsudMallick commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@alperozturk96 updated lib version from ed9da9b157a78af1c754dea197442c6727666e37 to 72a95a990f57135ef2b658d49a99dd193dcd6671 (latest one).

alperozturk96
alperozturk96 requested changes Jul 9, 2026
View reviewed changes

@alperozturk96 alperozturk96 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot build. Dependencies needs to be verified.

Can you try this command?

./gradlew  --write-verification-metadata pgp,sha256 help

@MaqsudMallick
update verification metadata
4824325 
Signed-off-by: MaqsudMallick <maqsudmallick@gmail.com>
@MaqsudMallick

MaqsudMallick commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

@alperozturk9 Done

@alperozturk96 alperozturk96 added this to the Nextcloud App 34.1.0 milestone Jul 9, 2026
@alperozturk96 alperozturk96 merged commit cc36cfe into nextcloud:master Jul 9, 2026
16 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alperozturk96 alperozturk96 alperozturk96 approved these changes
@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

3. to review enhancement feedback-requested

Projects

None yet

Milestone

Nextcloud App 34.1.0

Development

Successfully merging this pull request may close these issues.

Share links don't use pretty URL format

4 participants

@MaqsudMallick @tobiasKaminsky @alperozturk96 @AndyScherzinger