Bugfix and automated tests for #15636: deleting from slideshow #16184
Conversation
PhilLab
force-pushed
the
test_15636_deleting_from_slideshow
branch
from
e5ffcc9 to
8a358be
Compare
There was a problem hiding this comment.
@alperozturk96 during developing the automated tests, a bug was discovered and fixed in the same PR. This is why this file was touched.
Can you review the fix and the tests, so both can be merged?
PhilLab
force-pushed
the
test_15636_deleting_from_slideshow
branch
from
8a358be to
b31803f
Compare
PhilLab
force-pushed
the
test_15636_deleting_from_slideshow
branch
from
b31803f to
0fa8039
Compare
Testing the case of localOnly files. As the deletion logic differs per scenario, tests for the online scenario will also need to be added. Signed-off-by: Philipp Hasper <vcs@hasper.info>
Otherwise, the localOnly file deletion will not update the UI. Signed-off-by: Philipp Hasper <vcs@hasper.info>
The remote + offline test case had to be ignored due to two reasons 1) Broken App behavior - The UX is indeed broken, as from a user perspective, nothing happens with the file when deleting it. The offlineOperation is put on the worker stack, but the user doesn't see anything from it - Even when coming back online, it is completely unreliable when the deletion will be finally done. It might happen 5 or 10 minutes later 2) Broken test mock - The mocked connectivityService doesn't work as expected, because the OfflineOperationsWorker has its own service, and thus might still execute the deletion, but just at an unforseable time during the test execution - see problem 1). Signed-off-by: Philipp Hasper <vcs@hasper.info>
…e list The existing test cases varied by configuration: local vs. remote, online vs. offline. This is now extended by also starting at different entry points: beginning, end and middle of the list. Signed-off-by: Philipp Hasper <vcs@hasper.info>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
PhilLab
changed the title
2 participants
This tests the deletion behavior when deleting from slide show, fixed in #15636. It also fixes another bug which was uncovered during the automated tests, where the view pager was not correctly updated.
This PR requires #16145 to be merged first, as the automated tests also stumble upon the same timing issue fixed (and tested!) in said PR.