Skip to content

fix(NcDateTimePicker): warn about usage of non-standard formatting tokens - #8934

Merged
odzhychko merged 1 commit into
mainfrom
8931-NcDateTimePicker-warn-usage-non-standard-format-tokens
Sep 18, 2026
Merged

odzhychko merged 1 commit into
mainfrom
8931-NcDateTimePicker-warn-usage-non-standard-format-tokens

Conversation

@odzhychko

@odzhychko odzhychko commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Their usage was never intentionally supported.
The warning is added to warn users about their future removal.

☑️ Resolves

Prepares resolving #8931.

Completely resolving #8931 might involve throwing an error if such tokens are enabled.

This PR only adds a warning.

🖼️ Screenshots

No visual change

🚧 Tasks

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@odzhychko odzhychko added this to the 9.10.0 milestone Sep 7, 2026
@odzhychko odzhychko added 3. to review Waiting for reviews feature: datepicker Related to the date/time picker component Developer experience DX labels Sep 7, 2026
@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.49%. Comparing base (5798327) to head (ba91fe1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8934      +/-   ##
==========================================
+ Coverage   58.27%   58.49%   +0.22%     
==========================================
  Files         123      124       +1     
  Lines        4443     4465      +22     
  Branches     1325     1328       +3     
==========================================
+ Hits         2589     2612      +23     
+ Misses       1575     1574       -1     
  Partials      279      279              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@susnux susnux modified the milestones: 9.10.0, 9.12.1 Sep 13, 2026

@susnux susnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@susnux

susnux commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

@odzhychko please resolve the conflicts

…kens

Their usage was never intentionally supported.
The warning is added to warn users about their future removal.

Relates to #8931

Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
@odzhychko
odzhychko force-pushed the 8931-NcDateTimePicker-warn-usage-non-standard-format-tokens branch from b01c15c to ba91fe1 Compare September 18, 2026 13:53
@odzhychko
odzhychko merged commit 3ceda0e into main Sep 18, 2026
27 checks passed
@odzhychko
odzhychko deleted the 8931-NcDateTimePicker-warn-usage-non-standard-format-tokens branch September 18, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews Developer experience DX feature: datepicker Related to the date/time picker component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants