[stable8] fix(NcProgressBar): properly assign attributes - #8860
Draft
backportbot[bot] wants to merge 1 commit into
Draft
backportbot[bot] wants to merge 1 commit into
backportbot[bot] wants to merge 1 commit into
Conversation
fix(NcProgressBar): properly assign attributes Logically passing attributes like `aria-label` or `aria-describedby` to give information about the progress are expected to label the `progress` component and not a wrapper with `role = representation`. So this forwards the attributes to the actual progress element. But special attributes like `class` or `style` are expected to only affect the outer wrapper "public api" of the component. AI: AI was used for unit test generation but afterwards reviewed by me. Assisted-by: ClaudeCode:claude-opus-5 Co-authored-by: Peter R. <peter.ringelmann@nextcloud.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> [skip ci]
backportbot
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8851
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.