Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions lib/avatar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export interface AvatarUrlOptions {
isDarkTheme?: boolean

/**
* If the given user is is a guest user.
* If the given user is a guest user.
* This is needed as guest users use a different API endpoint.
*
* @default false
Expand All @@ -28,6 +28,19 @@ export interface AvatarUrlOptions {
* @default 64
*/
size?: 64 | 512

/**
* Fall back to a generated guest avatar if no avatar is found for the user.
* Has no effect when `isGuestUser` is `true`.
*
* @default false
*/
guestFallback?: boolean

/**
* Cache-busting value appended as a `v` query parameter.
*/
version?: string | number
}

/**
Expand All @@ -51,8 +64,19 @@ export function generateAvatarUrl(user: string, options?: AvatarUrlOptions): str
? '/dark'
: ''

return generateUrl(`/avatar${guestUrl}/{user}/{size}${themeUrl}`, {
const url = generateUrl(`/avatar${guestUrl}/{user}/{size}${themeUrl}`, {
user,
size,
})

const query = new URLSearchParams()
if (options?.guestFallback) {
query.set('guestFallback', 'true')
}
if (options?.version !== undefined) {
query.set('v', String(options.version))
}

const queryString = query.toString()
return queryString ? `${url}?${queryString}` : url
}
18 changes: 18 additions & 0 deletions tests/avatar.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,22 @@ describe('generateAvatarUrl', () => {
expect(generateAvatarUrl('alice', { isGuestUser: true, isDarkTheme: true })).toBe('//index.php/avatar/guest/alice/64/dark')
expect(generateAvatarUrl('john', { isGuestUser: true, isDarkTheme: true, size: 512 })).toBe('//index.php/avatar/guest/john/512/dark')
})

it('should append guestFallback query parameter if set', () => {
expect(generateAvatarUrl('alice', { guestFallback: true })).toBe('//index.php/avatar/alice/64?guestFallback=true')
expect(generateAvatarUrl('alice', { guestFallback: false })).toBe('//index.php/avatar/alice/64')
})

it('should append v query parameter if version is set', () => {
expect(generateAvatarUrl('alice', { version: 3 })).toBe('//index.php/avatar/alice/64?v=3')
expect(generateAvatarUrl('alice', { version: 'abc' })).toBe('//index.php/avatar/alice/64?v=abc')
})

it('should append both query parameters when combined', () => {
expect(generateAvatarUrl('alice', { guestFallback: true, version: 3 })).toBe('//index.php/avatar/alice/64?guestFallback=true&v=3')
})

it('should still append guestFallback for guest avatars even though the backend ignores it', () => {
expect(generateAvatarUrl('alice', { isGuestUser: true, guestFallback: true })).toBe('//index.php/avatar/guest/alice/64?guestFallback=true')
})
})
Loading