Skip to content

Remove NNN #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gonzaponte wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove NNN #968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4485667
Use Cluster.empty instead of NNN
gonzaponte Jul 28, 2026
e07d8bc
Remove NNN
gonzaponte Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions invisible_cities/cities/components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@
from .. types .ic_types import NoneType
from .. types .ic_types import xy
from .. types .ic_types import NN
from .. types .ic_types import NNN
from .. types .ic_types import minmax
from .. types .ic_types import types_dict_summary
from .. types .ic_types import types_dict_tracks
Expand Down Expand Up @@ -1001,7 +1000,7 @@ def build_pointlike_event(pmap, selector_output, event_number, timestamp):
try:
clusters = reco(xys, qs)
except XYRecoFail:
c = NNN()
c = Cluster.empty()
Z = tuple(NN for _ in range(0, evt.nS1))
DT = tuple(NN for _ in range(0, evt.nS1))
Zrms = NN
Expand Down
5 changes: 0 additions & 5 deletions invisible_cities/types/ic_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,6 @@

Tuple2Dor3D = Union[Tuple[float, float], Tuple[float, float, float]]

class NNN:

def __getattr__(self, _):
return NN


class xy:
def __init__(self, x, y):
Expand Down
7 changes: 0 additions & 7 deletions invisible_cities/types/ic_types_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
from . ic_types import minmax
from . ic_types import xy
from . ic_types import NN
from . ic_types import NNN

from pytest import raises

Expand Down Expand Up @@ -89,9 +88,3 @@ def test_xy(xy, a, b):
np.isclose (xy.R , r, rtol=1e-4)
np.isclose (xy.Phi, phi, rtol=1e-4)
np.allclose(xy.pos, pos, rtol=1e-3, atol=1e-03)


@given(text(min_size=1, max_size=10, alphabet=ascii_letters))
def test_NNN_generates_NN_for_every_attribute_name(name):
nnn = NNN()
assert getattr(nnn, name) == NN
Loading