fix: support automate module name with parsing cap#2574
Open
pohanhuang wants to merge 3 commits into
Open
Conversation
Signed-off-by: pohanhuang <pohan.huang@suse.com>
Signed-off-by: pohanhuang <pohan.huang@suse.com>
Signed-off-by: pohanhuang <pohan.huang@suse.com>
Collaborator
|
Thanks! Before jumping into review, I don't think #2571 broke the existing behavior, did it? It reverted a PR that has unintended side effect in 5.4 and 5.5. |
Contributor
Author
|
@holyspectral exactly, using this new caps would ensure even if the scanner update, the behavior stays the same. |
Collaborator
|
@pohanhuang okay then perhaps you want to modify the case description a little bit? It was worded like the revert PR caused the issue. |
Contributor
Author
|
@holyspectral Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add new parsing capability for JAR manifest to ensure backward-compatible behavior across scanner versions.
Previously, reverting #2294 (via #2571) exposed a gap: the Automatic-Module-Name field in MANIFEST.MF was not consistently handled, causing module name resolution to differ between scanner versions.
This fix adds explicit parsing caps so the behavior stays stable regardless of whether #2294 is present or not.
Related PR
#2294, #2571
Test
Scan docker.io/pohanhuangtw/demo-java-service:latest, verify:
No false positive CVE-2024-46985
No false positive CVE-2024-46997
[pre adding parsing cap: 5.5.2]
[After adding caps]
