fix(cert-upgrader): remove hardcoded cert-upgrader-uid annotation to prevent Helm drift#543
Open
isantospardo wants to merge 1 commit into
Open
Conversation
…prevent Helm drift
The cert-upgrader CronJob template previously hardcoded:
annotations:
cert-upgrader-uid: ""
The upgrader job mutates this annotation at runtime to store its
execution UID. Because the chart rendered a static empty value,
ArgoCD always detected drift after the first execution.
Signed-off-by: Iago Santos <iago.santos.pardo@adfinis.com>
|
Raised SUSE ticket #01845879 to have this reviewed and merged |
Contributor
|
@isantospardo thanks for the contribution! When the annotation is removed, I can see it causes problem here as the Could you check if it still works in your environment when changing it to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cert-upgrader CronJob template previously hardcoded:
The upgrader job mutates this annotation at runtime to store its execution UID. Because the chart rendered a static empty value, ArgoCD always detected drift after the first execution.
Closes #544