Repository navigation
Fix blank holes in line-by-line derotation - #76
Draft
divya-git03 wants to merge 2 commits into
Draft
divya-git03 wants to merge 2 commits into
divya-git03 wants to merge 2 commits into
Conversation
divya-git03
marked this pull request as draft
November 2, 2026 14:01
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft PR implements a small neighbour-based interpolation step to address blank holes produced by the existing forward-mapping algorithm in line-by-line derotation.
Tests
The two failures are golden-image regression comparisons. Investigation showed that the changed pixels in both fixtures were previously blank pixels and are now interpolated. No previously nonblank pixels were changed in those comparisons.
Review requested
This is an initial draft focused only on interpolation using the current algorithm, as suggested in the issue discussion. The interpolation threshold is an initial implementation choice and would benefit from maintainer feedback.
Could you advise whether the expected golden-image fixtures should be updated to reflect the intended interpolation behaviour?
Displacement-field improvements are intentionally outside this PR's scope.