Repository navigation
Dx12: club crests across the site - #446
Merged
Merged
Conversation
Carry3's generated crests for COR, FAL, OST, KEL, ROV, DUN, VAN, HBC, ELM, TES: the baked-in checkerboard is cut away, framed badges are filled white inside, frameless ones get a thin white outline so they read on dark backgrounds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…too (#443) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
One shared Crest component (decorative, alt="", lazy) with the kit chip as fallback; crests on the score band and slim bar, the Hub, line-ups, pre-match, turning points, Stats and the player spotlight. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@momomojun #443 队徽接进网站:20 张队徽是 Carry3 生成的,已经去好背景。比分区、首页大厅、阵容、赛前、转折点卡片、数据页都放上了,按 Carry3 的要求放大了(比分区 80px,手机 36px)。找不到队徽时退回原来的队色点。415 个测试通过。检查通过麻烦帮忙合。另外:首页大厅在 375 宽手机上本来就有约 510px 宽(main 上也这样,不是这个 PR 引起的),我另外修。 |
…; Hub fits at 375px (#443) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@momomojun 已加上 Carry3 要的上下排列(队徽在上、队名在下,时间在比分上方),并修好了首页在 375 手机上左右滑的问题。415 个测试通过,麻烦尽快检查合并,合完我们就定版录视频。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #443
What
All 20 fictional clubs now have a crest, shown wherever a team is named.
pivot_core/sim/world.pyCLUBS. Backgrounds were removed so each is a transparent 256×256 PNG inapps/web/public/crests/<short>.png(short name lower-cased). The Lunsford crest was re-cut so the checker inside the crescent is transparent too (5ae74b5). All are fictional, no real club marks.components/Crest.tsx:<Crest short="TES" size={48} fallback={…} />renders<img src="/crests/tes.png" alt="" aria-hidden width height loading="lazy" decoding="async">. It is decorative because the team name always sits next to it. An unknown club, or an image that fails to load, falls back to the kit-colour dot or chip used before.PreMatch.tsxaddsTeamKit(crest, with the kit dot as fallback) for the pre-match and line-up headers.public/to the root ofdist/, andpivot_api.singlemounts the wholedist/at/, so/crests/*.pngis served the same way as/favicon.svg.Where they appear, and how big
The direction was that fans recognise a crest faster than a name, so the crest should be the main identifier and not a small decoration.
Left unchanged: kit-colour keys in charts (momentum, the period bars, the pre-match bars header, the ground tally), person swatches, the match picker
<select>, and What-if (team names there are short inline labels inside tables).Live-score layout
Also fixes the Hub overflow at 375px found while checking crests
On
mainthe Hub was about 510px wide on phones. A round's schedule rows kept their fixed desktop columns, because the:has()rule for the round list outranked the phone rule. Under 720px:scrollWidthequalsinnerWidthon/at 375 and 320 in en, zh and es, and on the match page at 375 in all three languages.Checks
pnpm run lintandpnpm exec vitest runpass (415 tests, including a newcrest.test.ts).Screenshots
Hub, 1440

Hub, 375

Score band, 375

Score band and line-ups, 1440

Preview (form and table) with the slim bar, 1440

🤖 Generated with Claude Code