Repository navigation
Dx10 · 网站标志里的字母 o 换成一个足球 - #444
Merged
Merged
Conversation
The top bar, error page and hub draw the ball inline (rim in the text colour); wordmark.svg, favicon.svg and the PNG icons use the same drawing, and the docs site pages carry it as an inline favicon. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
做了什么
网站名字 pivot 里的字母 o 换成了一个小足球(中间一块是 Pivot 的黄色,和 p 里的黄点呼应)。所有出现标志的地方都换了:
浅色和深色模式下都看得清:足球的外圈跟着文字颜色走,深色背景上是白圈,浅色背景上是黑圈。
需要队友做什么
怎么确认它能用
仓库首页的标志和浏览器小图标(左:浅色系统;右:深色系统。标志的文字颜色跟系统走,和原来一样):
类型检查通过,前端 48 组共 412 个测试全部通过。
Closes #441
给写代码的同学
apps/web/src/components/Wordmark.tsx:新增Ball,内联 SVG,外圈stroke="currentColor",面板缩到 0.935 倍放在外圈里面,这样白色外圈不会盖住黑色块;useId()给 clipPath 一个唯一 id。字母拆成iv+ 球 +t。apps/web/src/styles/base.css:.brand .wordmark-o宽高 .54em,略微超出 x 高度,像圆形字母一样。apps/web/public/wordmark.svg:原来 o 的圆环路径换成同一个足球;外圈用已有的ink-s类,跟着prefers-color-scheme变色。apps/web/public/favicon.svg改成深色圆角方块里的足球(16px 下比 p 更好认);favicon-32.png、apple-touch-icon.png用无头 Chrome 从这个 SVG 重新导出(32px 带透明背景)。public/logo.svg(只有 p)没改。docs/site/*.html、docs/plan/handbook.template.html、scripts/build_docs.py:加一行内联 data URI 的 favicon,重新生成页面也会保留。apps/web/src/i18n/hardcoded.test.ts:把iv加进「各语言都一样的词」。docs/design/*.html里的旧设计稿没动,它们是历史稿。d/Dx10-Dx11-screenshots分支,只为 PR 引用,不要合并那个分支。🤖 Generated with Claude Code