Skip to content

Ax93: copy review, round 2 (follow, turning points, board) - #440

Merged
momomojun merged 3 commits into
mainfrom
a/Ax93-copy-review-2
Oct 28, 2026
Merged

momomojun merged 3 commits into
mainfrom
a/Ax93-copy-review-2

Conversation

@Carry3

@Carry3 Carry3 commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Closes #437

Built on #439 (merge that first).

Round 2 of the copy review: the keys round 1 left alone while #435 was in flight, plus the new follow-feature text (merged origin/main with #438 first; no conflicts). Only changed lines are touched in the message files.

Notable changes (en)

Key Before After
board.latest Latest pivot · {minute}′ Latest turning point: {minute}′
board.watching Watching for the first pivot Watching for the first turning point
board.pivots / post.pivots Pivots Turning points
board.beforePivot the 5 minutes before the {minute}′ pivot …the {minute}′ turning point
board.legend …in this action or pivot. …in this action or turning point.
board.noSwingLede A pivot marks where the run of play turned… A turning point marks where the run of play swung…
stamp.rejected Not a pivot Not a turning point
pivots.empty No pivots yet. Watching the momentum line. No turning points yet. Watching the momentum line.
post.pivotsNote …for the full explanation, checked against the match data. …for the full explanation, with every number checked against the match data.
detail.pitchNote {from}′–{to}′ · {team} attack → {from}′–{to}′: {team} attack →
detail.noDraw " · team instruction, no on-ball action to draw" " (a team instruction, with no on-ball action to draw)"
detail.outside " · outside the timeline window, so it has no mark on it" " (outside the timeline window, so it has no mark there)"
player.passes (+ value) Passes · accuracy: 18 · 83% Passes (accuracy): 18 (83%)
player.inMoments In the moments: In the turning points:
wi.an.m.seeds Seeds Paired replays
wi.an.m.seedsValue Paired: both versions of a run share a seed (base {seed}) Both versions of each run start from the same random draw (base {seed})
inv.rule Involved means {name} made, received, or came on or went off in… Involved means {name} played or received the ball, came on or went off in…

follow., pm., spot., story., moments., open., pivot.* read fine in en and were left as they are.

zh / es

  • zh: spaces between Chinese and Latin names in follow.team, follow.teamOff, follow.stop, board.shapeVs; board.latest 最新转折点:{minute}′; stamp.rejected 不算转折点 (matches trace.outcome.rejected); · removed from pitch notes and passes; seeds phrased as 配对重放 / 同一组随机抽样; inv.rule clarified.
  • es: board.latest without ·; post.pivots "Giros" (matches board.pivots); player.inMoments "En los giros:"; inv.rule uses "giro" and "jugó o recibió el balón"; seeds phrased as "Repeticiones emparejadas" / "mismo sorteo aleatorio"; pitch notes without ·.

Docs

  • README: "95 %", "34 %" etc. → "95%", "34%"; "Pivot 1, 12′" → "Turning point 1, 12′" (the What-if list label after Ax93: copy review, round 1 (English first) #439); "pivot cards / pivot detail / candidate pivots / pivot verdicts" → turning point(s). API paths and ids unchanged.
  • docs/submission/project-description.md: same percentage and "Turning point 1, 12′" fixes.
  • docs/submission/video-script.md: no quoted UI string changed, so not touched.

Counts

  • en: 18 strings, zh: 13, es: 11; 1 code line (PlayerCard passes value)
  • Tests updated: key-moments, player-card, i18n (exact strings)
  • pnpm run lint and pnpm exec vitest run: 412/412 pass

🤖 Generated with Claude Code

@Carry3

Carry3 commented Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

@momomojun 文字检查第二轮:关注球员、回放面板、转折点卡片这一块。界面上「pivot」统一改成「turning point」,去掉「·」,分析师方法说明里的 seed 改成「Paired replays」,中文名字前后补空格,README 的「95 %」改成「95%」。要在 #439 之后合。412 个测试通过。

@momomojun

Copy link
Copy Markdown
Member

@Carry3 #439 已经合了,所以这个 PR 现在和 main 冲突。请更新到最新 main、两边都保留,推上来以后网页测试一绿我就合。

🤖 Generated with Claude Code

@momomojun
momomojun merged commit 474cd82 into main Oct 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ax93 · 检查网站上的文字:英文为主,中文和西班牙文一起看

2 participants