Skip to content

Add cisco_xr_show_eigrp_neighbors.textfsm #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
GutturalOnion wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add cisco_xr_show_eigrp_neighbors.textfsm #2183

GutturalOnion wants to merge 9 commits into from
+152 −0

Conversation

@GutturalOnion
Copy link

@GutturalOnion GutturalOnion commented Aug 28, 2025

Add a textFSM template for the Cisco IOS-XR command "show eigrp neighbors".

@GutturalOnion
Create cisco_xr_show_eigrp_neighbors.textfsm
b478b44 
TextFSM template for the IOS-XR command "show eigrp neighbors".
@GutturalOnion
Merge pull request #1 from GutturalOnion/GutturalOnion-cisco-xr-show-…
67de8d4 
…eigrp-neighbors

Create cisco_xr_show_eigrp_neighbors.textfsm
@mjbear
Copy link
Collaborator

mjbear commented Aug 29, 2025

Add a textFSM template for the Cisco IOS-XR command "show eigrp neighbors".

Hi @GutturalOnion!

There are a few things that need added to this PR before it's ready.

  1. The index file needs updated so this template can be used (index order matters)
  2. Test data needs to be added so CI tests can run against this template to validate it works now and in the future. There are helper scripts to help with generating the structured test data from the raw CLI output.

Here are some tips on the development environment

Thank you!

@mjbear mjbear added the status: action required This issue requires additional information to be actionable label Aug 29, 2025
@mjbear mjbear changed the title Create the template file cisco_xr_show_eigrp_neighbors.textfsm Add cisco_xr_show_eigrp_neighbors.textfsm Aug 29, 2025
@mjbear mjbear marked this pull request as draft September 6, 2025 21:03
@mjbear
Copy link
Collaborator

mjbear commented Sep 21, 2025

@GutturalOnion
I hope you're doing well.
Please visit this PR on GitHub to review my guidance from a few weeks ago (Aug 28).

Please respond back with any questions.
Thank you!

@mjbear
Copy link
Collaborator

mjbear commented Oct 25, 2025

@GutturalOnion
Please review the August 28 requested changes.
If you have any questions, please respond back. We're here to assist.

@mjbear mjbear self-assigned this Nov 22, 2025
@mjbear mjbear added the WIP Work in Progress label Nov 22, 2025
@GutturalOnion GutturalOnion marked this pull request as ready for review January 30, 2026 18:11
@GutturalOnion GutturalOnion marked this pull request as draft January 30, 2026 18:14
@GutturalOnion
Merge branch 'networktocode:master' into master
d0f3270
@GutturalOnion
Add template for EIGRP neighbors command
5e7e3df 
Update the index file to match the CLI input for the Cisco IOS XR command "show eigrp neighbors"
@GutturalOnion
Refactor EIGRP neighbors template for consistency
e284a25
@GutturalOnion
Create .gitkeep
53efdc5
@GutturalOnion
Add files via upload
552dd76 
Test files for the IOS XR command "show eigrp neighbors"
@GutturalOnion GutturalOnion marked this pull request as ready for review January 30, 2026 21:11
@mjbear
Delete tests/cisco_xr/show_eigrp_neighbors/.gitkeep
84c352c 
Removing the .gitkeep file since there's test data in that directory now.
mjbear
mjbear reviewed Jan 31, 2026
View reviewed changes
@mjbear
Copy link
Collaborator

mjbear commented Jan 31, 2026 •
edited
Loading

Afterwards I did notice that the timestamp comment in several other existing templates uses the word "capture" when all it is doing is matching. It's cosmetic and maybe someday the other existing templates will get changed. 🤷

@mjbear mjbear removed WIP Work in Progress status: action required This issue requires additional information to be actionable labels Jan 31, 2026
@mjbear mjbear removed their assignment Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjbear mjbear mjbear approved these changes

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks itdependsnetworks is a code owner

@jmcgill298 jmcgill298 Awaiting requested review from jmcgill298 jmcgill298 is a code owner

@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner

@matt852 matt852 Awaiting requested review from matt852 matt852 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GutturalOnion @mjbear