Skip to content

utils: make fallback realpath safe #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cyberman wants to merge 1 commit into
base: master
Choose a base branch
from
Open

utils: make fallback realpath safe #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions utils/utils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
#include <sys/types.h>
#include <sys/stat.h>
#include <unistd.h>
#include <errno.h>

#include "utils/messages.h"
#include "utils/dirent.h"
Expand Down Expand Up @@ -472,14 +473,20 @@ int uname(struct utsname *buf) {

char *realpath(const char *path, char *resolved_path)
{
char *ret;
if (resolved_path == NULL) {
ret=strdup(path);
} else {
ret = resolved_path;
strcpy(resolved_path, path);
if (path == NULL) {
errno = EINVAL;
return NULL;
}
return ret;

/* Without a system realpath(), we cannot safely copy into an unknown-sized
* caller buffer. Provide only the allocating form.
*/
if (resolved_path != NULL) {
errno = ENAMETOOLONG;
return NULL;
}

return strdup(path);
}

#endif
Expand Down