Skip to content

Sync checks.yml so CodeQL analyses this repository's languages - #49

Merged
CybotTM merged 1 commit into
masterfrom
ci/sync-template-codeql-auto
Aug 6, 2026
Merged

Sync checks.yml so CodeQL analyses this repository's languages#49
CybotTM merged 1 commit into
masterfrom
ci/sync-template-codeql-auto

Conversation

@CybotTM

@CybotTM CybotTM commented Aug 6, 2026

Copy link
Copy Markdown
Member

Last of the 24 t3x-* repositories to reach the current org template. Twenty are already on it.

What this fixes

The template now passes languages: auto to the CodeQL reusable. Without it the call takes the input's default actions and scans workflow files only — and because GitHub disables code-scanning default setup the moment an advanced configuration uploads its first SARIF, rolling out the previous revision of this file silently switched off the JavaScript analysis that default setup had been performing.

auto detects rather than assumes: actions always, go on a go.mod or any .go file, javascript-typescript on a package.json or any JS/TS source. A PHP-only repository therefore gets actions alone and no pointless empty pass.

This is not theoretical

Re-enabling the analysis across the fleet tonight immediately surfaced findings that had been invisible while JavaScript went unscanned:

repository severity rule location
t3x-contexts HIGH js/clear-text-logging Build/playwright/tests/playwright/helper/login.setup.ts:116 and :126
t3x-cowriter MEDIUM js/xss-through-exception Resources/Public/JavaScript/Ckeditor/CowriterDialog.js:941

Those are pre-existing defects, not new ones — they were simply unreportable.

Scope

One file, .github/workflows/checks.yml, byte-identical to netresearch/.github/templates/typo3-extension/.github/workflows/checks.yml (blob 787510c1), verified with cmp. The drift check enforces that byte-identity, so no per-repository variation is possible here.

Copilot AI lite review requested due to automatic review settings August 6, 2026 01:19
@github-actions github-actions Bot added the ci label Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
actions/step-security/harden-runner b09bb98e06d4d774595224525879c09bc6e98c40 🟢 7.9
Details
CheckScoreReason
Binary-Artifacts🟢 10no binaries found in the repo
Branch-Protection🟢 8branch protection is not maximal on development and all release branches
CI-Tests🟢 106 out of 6 merged PRs checked by a CI test -- score normalized to 10
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Code-Review🟢 10all changesets reviewed
Contributors🟢 6project has 2 contributing companies or organizations -- score normalized to 6
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Dependency-Update-Tool🟢 10update tool detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Maintained🟢 1028 commit(s) and 5 issue activity found in the last 90 days -- score normalized to 10
Packaging⚠️ -1packaging workflow not detected
Pinned-Dependencies🟢 6dependency not pinned by hash detected -- score normalized to 6
SAST🟢 10SAST tool is run on all commits
Security-Policy🟢 10security policy file detected
Signed-Releases⚠️ -1no releases found
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
Vulnerabilities⚠️ 021 existing vulnerabilities detected

Scanned Files

  • .github/workflows/checks.yml

The template now passes `languages: auto` to the CodeQL reusable. Without
it the call takes the default `actions` and scans workflow files only —
and because GitHub disables code-scanning default setup as soon as an
advanced configuration uploads SARIF, the earlier rollout of this file
silently switched off the JavaScript analysis that default setup had been
doing.

`auto` detects rather than assumes: actions always, go on a go.mod or any
.go file, javascript-typescript on a package.json or any JS/TS source.

Not theoretical — re-enabling it across the fleet tonight immediately
surfaced findings that had been invisible: two HIGH js/clear-text-logging
in netresearch/t3x-contexts and one MEDIUM js/xss-through-exception in
netresearch/t3x-cowriter.

The file stays byte-identical to the template.

Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated approval for maintainer PR

All automated quality gates passed. See SECURITY_CONTROLS.md for compensating controls.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@CybotTM
CybotTM force-pushed the ci/sync-template-codeql-auto branch from 7eb384e to dc61456 Compare August 6, 2026 01:20
@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2026

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated approval for maintainer PR

All automated quality gates passed. See SECURITY_CONTROLS.md for compensating controls.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@CybotTM
CybotTM merged commit 80c00b2 into master Aug 6, 2026
49 of 50 checks passed
@CybotTM
CybotTM deleted the ci/sync-template-codeql-auto branch August 6, 2026 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants