ci: analyse every language CodeQL detects, not just workflows - #48
Merged
Conversation
Sync .github/workflows/checks.yml with the current org template so the CodeQL reusable is called with `languages: auto`. Without that input the call falls back to the default `actions`, which scans workflow files only. Because GitHub disables code-scanning default setup as soon as an advanced configuration uploads SARIF, the previous revision silently switched JavaScript analysis off in every repository that ships JS. The file is now byte-identical to templates/typo3-extension/.github/workflows/checks.yml in netresearch/dot-github (blob 787510c). Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Automated approval for maintainer PR
All automated quality gates passed. See SECURITY_CONTROLS.md for compensating controls.
|
There was a problem hiding this comment.
Automated approval for maintainer PR
All automated quality gates passed. See SECURITY_CONTROLS.md for compensating controls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs
.github/workflows/checks.ymlwith the current org template attemplates/typo3-extension/.github/workflows/checks.ymlinnetresearch/dot-github. The file is byte-identical to that template — verified withgit hash-object, blob787510c12e6d54db2d521aeb2d1961344db4fb1c.Why this revision matters
The template revision being adopted here passes
languages: autoto the CodeQL reusable workflow. Without that input the call takes the reusable's default ofactions, which scans workflow files and nothing else. That is not merely a narrower scan: GitHub disables code-scanning default setup as soon as an advanced configuration uploads SARIF, so the earlier rollout silently switched JavaScript analysis off in the repositories that ship JS, with no failing check to signal it.Verification
The same change has already completed a
javascript-typescriptanalysis ont3x-nr-vault,t3x-nr-repurposeandt3x-nr-temporal-cache, with zero new findings in all three.Single-file change, no extension code touched.