fix(merge-gate): re-poll UNKNOWN merge state before denying; document silent queue drops - #140
Merged
Merged
Conversation
… silent queue drops UNKNOWN usually means GitHub is still computing after a fresh push — the gate denied a legitimate merge on it (live). Bounded 3x3s re-poll inside the PreToolUse hook, then normal evaluation (persistent UNKNOWN still denies). merge-gate-watcher: a queued PR can silently leave the queue while reading CLEAN — verify isInMergeQueue, re-arm once via --disable-auto/--auto, then diagnose. Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
github-actions
Bot
added
documentation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two findings from live use of the merge gate (
/retrosweep):merge-gate.sh:mergeStateStatus: UNKNOWNusually means GitHub is still computing (observed right after an adjacent merge) — the gate denied a legitimate merge on it. Bounded re-poll (3×3 s) inside the PreToolUse hook before evaluating; a persistent UNKNOWN still denies (fail-closed). Explicitly not a merge-driver loop —pr-status.sh --watchremains the watcher.merge-gate-watcher.md: a PR queued via--autocan silently leave the merge queue (isInMergeQueue: false,CLEAN, nothing merged — observed live). Verify queue state via GraphQL, re-arm once via--disable-auto/--auto, then diagnose instead of re-arming repeatedly.Came from /retro: yes