fix(ruff): ruff 0.16.0 compatibility - #41
Merged
Merged
Conversation
The reusable validate.yml Python-lint step now pins ruff 0.16.0 (netresearch/skill-repo-skill#184), which surfaces findings the previous unpinned ruff did not flag in scripts/detect_missing_tool.py: - I001: import block un-sorted -> reordered (json/re/sys), safe autofix - BLE001: blind `except Exception` on stdin read -> annotated with `# noqa: BLE001`; the handler intentionally fails open (returns) so the hook never breaks the calling tool. Behaviour unchanged. No EXE001/FURB105 present in this repo. Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The reusable
validate.ymlPython-lint step now pins ruff 0.16.0 (netresearch/skill-repo-skill#184). Under that pin,ruff check .fails onscripts/detect_missing_tool.pywith findings the previously-unpinned ruff did not flag.Findings before (ruff@0.16.0
check .)I001scripts/detect_missing_tool.py:7 — import block un-sortedBLE001scripts/detect_missing_tool.py:43 — blindexcept Exception(No
EXE001/FURB105present.format --check .was already clean.)Fixes (behaviour-preserving)
json,re,sys(ruff safe autofix).except Exception:on the stdin read with# noqa: BLE001and a reason. The handler intentionally fails open (return) so the detection hook never breaks the calling tool — narrowing the catch could let an error escape that must stay swallowed. Behaviour unchanged.Verify
uvx ruff@0.16.0 check .-> All checks passed!uvx ruff@0.16.0 format --check .-> cleanCame from /retro follow-up on the reusable ruff pin (netresearch/skill-repo-skill#184).