NRS-4588: feed attest-sbom from the secret-free subjects list - #350
Merged
Conversation
GitHub drops a job output wholesale when any part of it matches a
secret ("Skip output metadata since it may contain secret") - and raw
bake metadata carries the build definition incl. tokens interpolated
into build args. On netresearch/typo3-demo run 31057574829 that left
attest-sbom with an empty bake-metadata input: the prepare job parsed
zero subjects and the attest matrix died at startup, invisible in the
job rollup. build-container-bake.yml now exposes its filtered
sbom-subjects list (name+digest only) as a workflow output and
attest-sbom.yml prefers a new subjects input over bake-metadata,
erroring loudly when both are empty.
Signed-off-by: Sebastian Mendel <sebastian.mendel@netresearch.de>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub drops a job output wholesale when any part of it matches a secret (annotation: "Skip output 'metadata' since it may contain secret") — and raw bake metadata carries the build definition including tokens interpolated into build args. On netresearch/typo3-demo run 31057574829 this left attest-sbom with an empty bake-metadata input: prepare parsed zero subjects and the attest matrix died at startup, invisible in the job rollup (all listed jobs green, run red). build-container-bake.yml now exposes its filtered sbom-subjects list (name+digest only, secret-free by construction) as a workflow output, and attest-sbom.yml prefers the new subjects input over bake-metadata, failing loudly when both are empty. The legacy metadata path also gets the non-object guard from #349.