Skip to content

NETOBSERV-2716 fix udn tab#1504

Open
jpinsonneau wants to merge 1 commit into
netobserv:mainfrom
jpinsonneau:2716
Open

NETOBSERV-2716 fix udn tab#1504
jpinsonneau wants to merge 1 commit into
netobserv:mainfrom
jpinsonneau:2716

Conversation

@jpinsonneau
Copy link
Copy Markdown
Member

@jpinsonneau jpinsonneau commented May 11, 2026

Description

Fix CUDN / UDN tab not handled (crashing)

Dependencies

n/a

Checklist

  • Does the changes in PR need specific configuration or environment set up for testing?
    • if so please describe it in PR description.
  • I have added thorough unit tests for the change.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Summary by CodeRabbit

Release Notes

  • New Features
    • Extended network traffic analysis to support ClusterUserDefinedNetwork and UserDefinedNetwork resource types. The traffic tab now automatically applies appropriate filters when viewing these resources, enabling seamless traffic monitoring for user-defined networks.

Review Change Stack

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 11, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign oliviercazade for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jpinsonneau jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label May 11, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: aba471e2-7100-4daf-8158-f7a1796f08fe

📥 Commits

Reviewing files that changed from the base of the PR and between 96e3a1e and 641e06e.

📒 Files selected for processing (1)
  • web/src/components/netflow-traffic-tab.tsx

📝 Walkthrough

Walkthrough

NetflowTrafficTab extends its resource kind switch logic to support ClusterUserDefinedNetwork and UserDefinedNetwork. Both cases configure forced netflow filters using the udns filter key with bidirectional matching, deriving filter values from resource metadata.

Changes

NetflowTrafficTab UDN Support

Layer / File(s) Summary
New Resource Kind Handlers
web/src/components/netflow-traffic-tab.tsx
Switch statement adds cases for ClusterUserDefinedNetwork and UserDefinedNetwork, setting forcedFilters with udns key, equality comparison, and bidirectional match. Filter value uses obj.metadata.name for cluster resources and ${namespace}.${name} for namespaced resources.

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the fix addresses CUDN/UDN tab crashing, matching the code changes. However, no unit tests were added despite the template requiring them, and no QE requirement was selected from the checklist. Check the 'No QE' or 'Regression tests only' option if appropriate, and either add unit tests or justify their absence in a comment.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title references the issue number (NETOBSERV-2716) and mentions 'udn tab', which aligns with the code changes adding support for UDN/CUDN resource kinds in the netflow traffic tab.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Linked repositories: Your configuration references 2 linked repositories, but your current plan allows 1. Analyzed netobserv/netobserv-operator, skipped netobserv/flowlogs-pipeline.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

New image:

quay.io/netobserv/network-observability-console-plugin:b870419

It will expire in two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=b870419 make set-plugin-image

@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.40%. Comparing base (96e3a1e) to head (641e06e).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
web/src/components/netflow-traffic-tab.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1504      +/-   ##
==========================================
- Coverage   52.42%   52.40%   -0.02%     
==========================================
  Files         233      233              
  Lines       12452    12456       +4     
  Branches     1564     1564              
==========================================
  Hits         6528     6528              
- Misses       5310     5314       +4     
  Partials      614      614              
Flag Coverage Δ
uitests 56.51% <0.00%> (-0.03%) ⬇️
unittests 40.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
web/src/components/netflow-traffic-tab.tsx 53.08% <0.00%> (-2.76%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants