Open
Conversation
Author
|
As a side note: this creates sparse files on the backup destination as well as with the digest on the backup source. This is OK and expected. But I may further need to overthink / test this. There is still a difference between a block with zeroes and a gap which make me nervous somehow. |
Owner
|
That looks great – I can see you’ve put a lot of work into it. I’m currently modernizing my backup server, so I’ll definitely be testing your solution as well. I’ll take a closer look at it soon. Nice work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey... I now have tested the --era switch in vitro as well as on a live system. It may be ready for prime time, so here is the pull RQ. I add my test scripts here, just in case you want to give it a try. If necessary, I can provide SSH access to a live test system (one of those little things depicted with the last pull RQ).
era-test.sh
digest-test.sh
delta-test.sh