Repository navigation
fix(doctor): read active daemon logs on Windows - #2786
Merged
Aaronontheweb merged 6 commits intoNov 7, 2026
Merged
Aaronontheweb merged 6 commits into
Aaronontheweb merged 6 commits into
Conversation
The message formats the failure rate with the current culture. CI wrote "50 %" and the test expected "50%", so the test failed on Ubuntu. The test now checks the severity and the counts "(1/2)", which prove that doctor read and classified the open log.
Collaborator
|
Thanks for the fix. The I pushed one commit to your branch ( I also approved the CI runs for the new head. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2704
#2704
netclaw doctorcan read the active daemon log while the daemon keeps it open for append.The regression test keeps the writer open and checks one success marker and one timeout marker.
Tests:
dotnet test Netclaw.slnx -c Release --no-restore --filter "Category!=NativeShell": the CLI test assembly reports 2,674 passed, 115 skipped, and two timezone failures. The clean current base reproduces both failures.dotnet test Netclaw.slnx -c Release --no-build --no-restore --filter "Category=NativeShell": 1 passed.dotnet format Netclaw.slnx --verify-no-changes --no-restore --include src/Netclaw.Cli/Doctor/MemoryCurationLlmDoctorCheck.cs src/Netclaw.Cli.Tests/Doctor/MemoryCurationLlmDoctorCheckTests.cs: passed.dotnet slopwatch analyze: passed with 0 issues.