Draft
Conversation
Comprehensive update to PRD_AND_ARCHITECTURE.md reflecting all features and changes from 2026 merged pull requests. New sections added: - Pre-Flight Validation: fail-fast authentication architecture with AuthCheckResult, AuthOutcome enum, two-tier error classification - Diagnostic Collection: nac-test-diagnostic.sh invocation and architecture - Platform Safety Gates: macOS Python version checks, PyATS git_info disable, SSL/fork safety measures - GitHub Templates: PR and issue template documentation Enhanced existing sections: - D2D hostname flow through DeviceExecutor to HTML reporting - Skipped device reporting pipeline with _last_resolver pattern - Test discovery relaxation with content-based detection - Environment variable naming conventions (NAC_TEST_ prefix) - Combined dashboard and xunit merger documentation - Worker memory tuning (MEMORY_PER_WORKER_GB) - Robot Framework exit codes - Dry-run support Maintenance: - Updated document version to 2.0 / 2026-03 / nac-test 2.0.0a1 - Fixed ToC anchors and cross-references - Standardized terminology (pre-flight hyphenation) - Removed obsolete REPORTING_PLAN_OPTION_D.md Co-Authored-By: Daniel Schmidt <noreply@example.com>
aitestino
changed the base branch from
main
to
release/pyats-integration-v1.1-beta
Merged
oboehmer
changed the base branch from
release/pyats-integration-v1.1-beta
to
main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive update to
PRD_AND_ARCHITECTURE.mdreflecting all features and architectural changes from 2026 merged pull requests through v2.0.0a1.Changes
New Deep-Dive Sections:
AuthCheckResult,AuthOutcome, two-tier error classificationnac-test-diagnostic.shinvocation, architecture, credential maskingEnhanced Existing Sections:
NAC_TEST_andNAC_TEST_PYATS_prefix standardization--dry-runflag for test validationDocument Maintenance:
REPORTING_PLAN_OPTION_D.mdStats: 1,257 insertions, 2,089 deletions across 2 files
Related Issues
Closes #596
Review Focus:
Ready for: Technical review and merge to main