Skip to content

MQTT Upgrade - attempt 2#1385

Open
helto4real wants to merge 7 commits into
mainfrom
mqtt-fix-2
Open

MQTT Upgrade - attempt 2#1385
helto4real wants to merge 7 commits into
mainfrom
mqtt-fix-2

Conversation

@helto4real
Copy link
Copy Markdown
Collaborator

@helto4real helto4real commented May 29, 2026

Breaking change

Proposed change

Upgrade the MQTT dependency. We are using MQTTnet that has a lot of breaking changes. This is a big overhaul of the MQTTManager to support these changes.

Also added integration tests.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • The code compiles without warnings (code quality check)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration are added/changed:

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

❌ Patch coverage is 78.87324% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 82%. Comparing base (0116c98) to head (b437273).

Files with missing lines Patch % Lines
...ensions.MqttEntityManager/AssuredMqttConnection.cs 75% 20 Missing and 10 partials ⚠️
Additional details and impacted files
@@         Coverage Diff          @@
##           main   #1385   +/-   ##
====================================
  Coverage    82%     82%           
====================================
  Files       202     201    -1     
  Lines      3941    4019   +78     
  Branches    444     457   +13     
====================================
+ Hits       3239    3331   +92     
+ Misses      532     489   -43     
- Partials    170     199   +29     
Flag Coverage Δ
unittests 82% <78%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@helto4real helto4real marked this pull request as draft May 30, 2026 06:45
@helto4real helto4real marked this pull request as ready for review May 31, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant