feat(PL-4896): trailing space detection for joy secret seal#245
Merged
feat(PL-4896): trailing space detection for joy secret seal#245
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
j-martin
reviewed
Feb 18, 2026
davidmdm
force-pushed
the
feat/PL-4896/warn-on-trailing-space-secret-seal
branch
from
e8716a0 to
55b034e
Compare
j-martin
approved these changes
Feb 18, 2026
davidmdm
requested review from
alexstojda,
ayahajar,
riclima and
silphid
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds trailing space detection when performing
joy secret seal.If this detected, the user will be prompted to trim the trailing space from the secret.
To opt-out of this check users can use the new flag
--no-prompt