Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the 0.62.0 gap: persist and record Codex quota-window reset observations (upstream steipete#3358), so Codex weekly boundaries are recovered from recorded observations across restarts instead of being estimated from the live window alone.
rust/src/providers/codex/reset_observations.rs: durable, DPAPI-wrapped observation store modeled on the Claudereset_observationspattern (singlecodexscope; observations deduped byresets_atkeeping the newest capture, sorted by reset time, bounded at 512 entries; staged atomic publish with failure cleanup).chart.rs: the Codex chart history now loads the persisted observations and records the live window's reset on every refresh, then passes them tocodex_quota_windows_from_cacheasobserved_next_resets(previously&[]— the gap). Read/merge failures degrade to the previously stored observations; the chart never breaks on a store error.Validation
cargo +1.98.0 fmt --all -- --check: cleancargo +1.98.0 clippy --workspace --all-targets -- -D warnings: cleancargo +1.98.0 test -p codexbar --lib: 2173 passed, 0 failed (1 ignored), including 7 new reset-observations tests (empty/foreign scope rejection, missing store, dedupe/capture-regression, sort, bounded log, unsupported version, DPAPI-wrapped payload)cargo +1.98.0 test -p codexbar-desktop-tauri: 461 passed / 1 failed (documented Isolate bootstrap payload test from real settings #684bootstrap_payload_exposes_every_provider_variantbaseline; backend-only diff, no frontend files)Upstream reference
steipete/CodexBar 0.62.0, quota-window reset observations (steipete#3358) — tag-pinned read-only.