[0.64.1] Animate budget disclosure chevron - #608
Conversation
Thermo-nuclear code-quality reviewVerdict: PASS. No maintainability findings. Reviewed head The change is a single transition on the existing Native proof is still required for this change: capture the chevron animating on a fresh Windows build, and with reduced motion turned on under Windows animation effects. That goes through the usual CUA evidence path. |
…ency' into codex/port-0.64.1-disclosure-transition
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Lane validation 2026-10-02 (head 531622f): Merged the preferred-currency port (codex/port-0.64.1-preferred-currency at its thermo-reviewed head 1c24b7b) into this branch; automatic merge, no conflicts — the disclosure CSS from a0de08c survives intact (budget-header chevron, 120ms ease transition, prefers-reduced-motion guard). Validation: cargo fmt --check clean; vitest 410/410 (68 files). The currency work carries its own validation from #609/#679 (cargo test codexbar 2172/0 and 2145/0, desktop 466/1 = known #684 bootstrap baseline, check-locale 881 OK, clippy -D warnings clean for diff). #608's own delta remains CSS-only. Pushed as fast-forward a0de08c..531622f; remote verified at 531622f. UI-affecting (chevron transition + currency picker): proofs queue after the in-flight #739 capture. |
UI proof (browser-use)Build commit: Driven over WebView2 CDP (port 9352) with browser-use only — no OS input, no clicks outside the page. Seed:
Caveats (both expected, neither caused by this PR's delta):
Screenshots (local, not committed), in |
Proof plan: PR #608 budget disclosure chevron (upstream 0.64.0 item 32)Build commit: 531622f (codex/port-0.64.1-disclosure-transition; includes the merged preferred-currency port). Exe: lane-b target debug (frontendDist build, NOT the dev-server exe). Proof-only patch: dirs shim — never committed. EnvironmentCODEXBAR_PROOF_HOME isolated (proof/679 kit home); CDP 9352; browser-use over CDP only (no OS input, no focus); proof-window-guard running. Limitation found at captureThe offline seed cannot produce a live pace budget row: getPaceBudget requires a future resetsAt on the metric snapshot, and the auto-refresh loop (do_refresh_providers_if_stale → codex fetch) replaces the seeded snapshot with a "not installed" error snapshot within ~1s of launch regardless of the seed guard (the refreshProviders force path bypasses it). With no live budget row, the 120ms transform animation on a real element cannot be observed through the DOM click path. What was proven instead (browser-use, PASS at capture)A0 Privacy: page scan — no emails/personal tokens.
Not coveredThe 120ms eased rotation on a REAL budget row (needs an online/live pace budget). The transform targets and the media-query suppression are proven through the app's own stylesheet + a real DOM node, which is the observable equivalent in this environment. |
Branch now carries both the budget disclosure chevron animation (120ms ease transition,
prefers-reduced-motionguard, on.menu-metric__budget-header::beforein menu-surface-layout.css) and the merged preferred-currency port (#609 thermo head 1c24b7b), so this PR can merge as one coherent 0.64.0/0.64.1 unit. Diff: a0de08c..531622f.Validation: cargo fmt --check clean; vitest 410/410 (68 files); no Rust changes in this merge beyond #609's validated work; 608's own delta is CSS-only (6 lines). Pushed fast-forward a0de08c..531622f (remote verified 531622f).