Repository navigation
fix: unbreak main after the Sogou removal and compile the dictionary crate in CI - #62
Merged
Merged
Conversation
…he dictionary crate in CI PR #59 removed the Sogou-only 串行打印机 entry but left the domain-vocabulary regression expecting it, which fails engine-english on main. It also changed read_rows' signature without updating spelling.rs, so the Rust dictionary port no longer compiled; CI did not notice because only the portable runtime crate ran there. Remove the expectation, fix the call, and add a CI job that runs Core/Portable/dictionary/test.sh against the committed fixtures. Refs #56 Refs #52 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #56, Refs #52.
问题
PR #59 合并后
main的 macOS CI 失败：该词条是 #59 刻意移除的搜狗独有数据，但
domainVocabulary回归仍要求它。同一 PR 还改了 Rust 词典端口中read_rows的签名而没更新spelling.rs，crate 无法编译；CI 的 cargo 作业只跑Core/Portable/Cargo.toml（运行时），没有覆盖Core/Portable/dictionary。变化
EngineRegression.swift：删除对串行打印机的期望。Core/Portable/dictionary/src/spelling.rs：去掉多余的None参数。.github/workflows/ci.yml：新增Portable dictionary (cargo test)作业，运行Core/Portable/dictionary/test.sh，在 Linux 上与提交的 fixtures 对比。验证（本机，合并后的 main 加本 PR）
test.sh engine-english通过；此前已在合并后的 main 上跑过quick其余单元、quality-baseline、dictionary-generator、source-bundle，全部通过。Core/Portable/dictionary/test.sh通过：965,919 行、32 个拼写方案与 Swift 生成结果逐字节一致，43 个 Swift/Rust 契约用例通过。🤖 Generated with Claude Code