Conversation
Contributor
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a router force-closes its downstream channel and receives a peer fulfill before the close confirms, the TLC becomes
RemoteRemovedwithout completing its removal handshake. On-chain reconciliation previously treated the existing removal reason as completion, skipping the upstream fulfill and potentially finalizing the channel while the payer remained inflight.Keep these unconfirmed forwarded fulfills eligible for recovery using the existing channel-scoped on-chain preimage evidence. Both live-actor and offline relay completion paths now persist
AppliedFlags::REMOVEonly after upstream delivery is accepted or durably queued. This distinguishes receiving the downstream fulfill from completing its upstream side effects, preserving retries until delivery and preventing subsequent recollection. No persisted fields are added, and the on-chain failure selection rules are unchanged.Validation:
make clippypasses, including native all-features, SQLite without default features, and WASM checks.cargo fmt --all -- --checkandgit diff --checkpass.Fixes #1660.