fix: prevent prefix-only on-chain preimage settlement stranding - #1656
Merged
Merged
Conversation
quake
force-pushed
the
fix/commitment-lock-full-payment-hash
branch
from
September 11, 2026 03:55
14535da to
0674521
Compare
quake
marked this pull request as ready for review
September 14, 2026 01:39
chenyukang
reviewed
Sep 14, 2026
| /// Which commitment-lock settlement witness layout this channel uses, | ||
| /// decided once at channel-open and never changed. | ||
| #[serde(default)] | ||
| pub commitment_contract_version: CommitmentContractVersion, |
Collaborator
There was a problem hiding this comment.
I think this need a migration?
chenyukang
reviewed
Sep 14, 2026
chenyukang
reviewed
Sep 14, 2026
jjyr
reviewed
Sep 15, 2026
jjyr
left a comment
jjyr
left a comment
Collaborator
There was a problem hiding this comment.
Please remove .superpowers
quake
force-pushed
the
fix/commitment-lock-full-payment-hash
branch
2 times, most recently
from
September 24, 2026 05:14
7eba8ed to
348c064
Compare
quake
force-pushed
the
fix/commitment-lock-full-payment-hash
branch
from
September 25, 2026 03:10
348c064 to
5d30078
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: negotiate and persist the ONCHAIN_FULL_PAYMENT_HASH commitment feature per channel; support legacy and v1 settlement witness layouts in channel builders and watchtower parsing; treat exact prefix-valid/full-hash-invalid on-chain preimages as failed settlements and fail forward immediately; add settlement-size, watchtower, reconciliation, and compatibility regression coverage. Depends on the matching fiber-scripts draft PR for the upgraded commitment-lock contract. Verification: focused reconciliation tests 25/25 passed; watchtower tests 28 passed; make check passed; make check-migrate passed; clippy and formatting passed. Full nextest has 29 environment failures: Cannot assign requested address.