Repository navigation
Conversation
3 of 4 tasks
There was a problem hiding this comment.
Pull request overview
Updates the Rust toolchain version used by this repository’s generated Docker build environments (Ubuntu focal, CentOS 7, and aarch64) by bumping the pinned Rust version in the generator script and the checked-in generated Dockerfiles.
Changes:
- Bump
RUST_VERSIONfrom1.92.0to1.95.0ingen-dockerfiles. - Update
ENV RUST_VERSIONto1.95.0in the generated Dockerfiles for focal, centos-7, and aarch64.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| gen-dockerfiles | Updates the single source-of-truth Rust version used when generating Dockerfiles. |
| focal/Dockerfile | Updates the pinned Rust toolchain version installed by rustup in the focal image. |
| centos-7/Dockerfile | Updates the pinned Rust toolchain version installed by rustup in the CentOS 7 image. |
| aarch64/Dockerfile | Updates the pinned Rust toolchain version installed by rustup in the aarch64 image. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-merge-queue Bot
pushed a commit
to nervosnetwork/ckb
that referenced
this pull request
May 10, 2026
### What problem does this PR solve? https://releases.rs/docs/1.95.0/ Problem Summary: Upgrade direct Rust pins to `1.95.0` and fix the clippy failures exposed by Rust `1.95.0`. ### What is changed and how it works? What's Changed: - [x] bump direct toolchain pins to `1.95.0` - [x] fix handwritten clippy fallout needed for `make clippy` - [ ] nervosnetwork/ckb-docker-builder#36 - [x] `cargo update` for `./Cargo.lock` ### Check List Tests - Manual test: `make clippy` Side effects - Breaking backward compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.