Mutable editors#29
Merged
Merged
Conversation
Add getters/setters for locale, groupSeparator, and allowNegative. Rebuild the internal ParsedNumberFormat and reformat the current value when these options change. Ensure number setter respects allowNegative. Add tests covering locale, separator, and allowNegative mutations.
Add mutable properties to controllers CurrencyEditingController: currencyName, currencySymbol, decimalSeparator DecimalEditingController: minimalFractionDigits, maximumFractionDigits, decimalSeparator Setters rebuild the format and reformat the current value when changed. Add tests verifying reformatting, no-op assignments (no notifications), getters, and factory subclass types
Expand documentation with quick start, configuration, runtime option changes, class hierarchy, and locale examples. Update example app to use CurrencyEditingController, DecimalEditingController, and IntegerEditingController; add currency/locale pickers, change UI layout and titles, and demonstrate mutable formatting options at runtime
Document known limitations in README (precision, grouping, fraction digits, RTL and runtime option changes) Clamp decimal fraction digits to 0–20 in ParsedNumberFormat Simplify RealPart parsing, handle grouping correctly, stop inserting an automatic zero, and return null width for StaticPart Minor parentheses cleanup in text controller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.