Skip to content

Remove PartLength and simplify currency handling #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thenixan merged 1 commit into from
Mar 16, 2026
Merged

Remove PartLength and simplify currency handling #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/mask_parser_iterator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ extension NumberFormatPartExt on String {
result.add(StaticPart(content));
content = '';
}
result.add(CurrencySignPart(currencySign));
result.add(StaticPart(currencySign));
} else {
content += char;
}
Expand Down
32 changes: 0 additions & 32 deletions lib/src/part_length.dart
View file
Open in desktop

This file was deleted.

34 changes: 0 additions & 34 deletions lib/src/parts.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import 'package:flutter/material.dart';
import 'package:number_editing_controller/src/grouping.dart';
import 'package:number_editing_controller/src/part_length.dart';

/// The result of formatting a single [NumberFormatPart].
class PartFormatResult {
Expand Down Expand Up @@ -36,9 +35,6 @@ class PartFormatResult {

/// A segment of a number format pattern that knows how to format its portion of input.
abstract class NumberFormatPart {
/// The length constraints of this part.
PartLength get length;

/// Formats the input [value] starting at [position] and returns the result.
PartFormatResult format(TextEditingValue value, int position);
}
Expand All @@ -48,9 +44,6 @@ class StaticPart extends NumberFormatPart {
/// The static text content.
final String content;

@override
PartLength get length => DeterminedPartLength(content.length);

StaticPart(this.content);

@override
Expand Down Expand Up @@ -84,12 +77,6 @@ class StaticPart extends NumberFormatPart {
}
}

/// A [StaticPart] that represents a currency symbol.
class CurrencySignPart extends StaticPart {
/// Creates a currency sign part with the given symbol [content].
CurrencySignPart(super.content);
}

/// A part that represents the integer portion of a number.
class RealPart extends NumberFormatPart {
/// The digit grouping configuration.
Expand All @@ -101,9 +88,6 @@ class RealPart extends NumberFormatPart {
/// Creates a [RealPart] with the given [grouping] and [allowNegative] flag.
RealPart(this.grouping, this.allowNegative);

@override
PartLength get length => AtLeastPartLength(1);

@override
PartFormatResult format(TextEditingValue value, int position) {
var i = 0;
Expand Down Expand Up @@ -204,24 +188,6 @@ class DecimalPart extends NumberFormatPart {
/// Creates a [DecimalPart] with the given length bounds and [decimalSeparator].
DecimalPart(this.minLength, this.maxLength, this.decimalSeparator);

@override
PartLength get length {
if (minLength == 0 && maxLength == 0) {
return DeterminedPartLength(0);
}
if (minLength == 0 && maxLength != 0) {
return VariablePartLength(
0,
maxLength + decimalSeparator.length,
);
}

return VariablePartLength(
minLength + decimalSeparator.length,
maxLength + decimalSeparator.length,
);
}

@override
PartFormatResult format(TextEditingValue value, int position) {
var i = 0;
Expand Down
Loading