Use NavigatorState in progress dialog callbacks#19
Merged
Conversation
Pass NavigatorState into _callback and call navigator.removeRoute instead of depending on a possibly unmounted BuildContext. Capture navigator.context for theming and push routes via that navigator. Check route.isActive (not context.mounted) so removing a nested navigator while a task is in-flight does not leave push() resolving null. Add a regression test for the nested-navigator removal case. Update example/pubspec.lock package versions and Dart SDK bound.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass NavigatorState into _callback and call navigator.removeRoute instead of depending on a possibly unmounted BuildContext. Capture navigator.context for theming and push routes via that navigator. Check route.isActive (not context.mounted) so removing a nested navigator while a task is in-flight does not leave push() resolving null. Add a regression test for the nested-navigator removal case. Update example/pubspec.lock package versions and Dart SDK bound.