refactor(editor): extract pure text-reinsertion helpers to text_reinsert module - #155
Merged
Merged
Conversation
…ert module Move the pure typographic-fidelity helpers (no Qt/UI/self state) out of app/editor/tab.py into a dedicated app/editor/text_reinsert.py. Pure code move, behaviour identical: fitz/doc/page are passed in as arguments so the helpers stay unit-testable headless. tab.py now imports _reinsert_edited_text from the new module; the now-unused `import html` is dropped from tab.py. Test imports updated to app.editor.text_reinsert (logic untouched). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pure refactor (step R2 of the editor modularity plan). No behavior change.
Moves the typography / text-reinsertion helpers (constants + 13 functions) out of
app/editor/tab.pyand into a new pure moduleapp/editor/text_reinsert.py.app/editor/tab.py: 1806 -> 1472 linesapp/editor/text_reinsert.py: new pure module (no UI imports, no import cycle)tests/test_editor_text_fidelity.py: import updated to point at the new moduleScope
Testing
Follow-up
Prepares the ground for R1 (extracting the
_rundispatcher).