Skip to content

Sync: sync/e3e451f01 #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nebius-devtools wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −6
Open

Sync: sync/e3e451f01 #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions nebius/common/v1/warning.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,13 @@ message Warning {

// Contains a Full Service/Method name or a select mask for a field.
// Examples:
// nebius.compute.v1.InstanceService
// nebius.compute.v1.InstanceService/Get
// spec.control_plane.version
// spec.network_interfaces.0.subnet_id
// items.0.spec.control_plane.version
// ```
// nebius.compute.v1.InstanceService
// nebius.compute.v1.InstanceService/Get
// spec.control_plane.version
// spec.network_interfaces.0.subnet_id
// items.0.spec.control_plane.version
// ```
string path = 7;

enum Target {
Expand Down
13 changes: 13 additions & 0 deletions nebius/compute/v1/instance.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,19 @@ message AttachedDiskSpec {
oneof type {
option (buf.validate.oneof).required = true;

// Attach an existing disk.
//
// Lifecycle:
// - The disk is preserved when the instance is deleted (it will be detached).
//
// Switching to a managed disk:
// - To delete the disk together with the instance, switch to ManagedDisk in the instance spec.
// - For the switch, `ManagedDisk.name` MUST match the current disk `name`
// (see DiskService.Get for the disk referenced by `ExistingDisk.id`).
// - When converting an ExistingDisk to a ManagedDisk, you must provide `ManagedDisk.name` and `ManagedDisk.spec`
// exactly as they are currently defined in the disk resource.
// Obtain the current values via `DiskService.Get` and copy them verbatim.
// If `ManagedDisk.spec` differs from the current disk spec, the instance update will fail.
ExistingDisk existing_disk = 2;
}

Expand Down
3 changes: 2 additions & 1 deletion nebius/compute/v1/instance_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ service InstanceService {
// Updates an existing VM instance with new configuration parameters.
rpc Update(UpdateInstanceRequest) returns (common.v1.Operation);

// Deletes a VM instance by its ID.
// Deletes a VM instance by its ID. Also deletes all the managed disks, declared in the instance spec.
// Fails if cannot delete any of the managed disks.
rpc Delete(DeleteInstanceRequest) returns (common.v1.Operation);

// Starts a stopped VM instance.
Expand Down