This repository was archived by the owner on Oct 5, 2022. It is now read-only.
using swipe to switch pages#92
Open
floridemai wants to merge 2 commits into
Open
Conversation
jh3y
reviewed
Feb 4, 2019
jh3y
left a comment
jh3y
left a comment
There was a problem hiding this comment.
Not pulled it down to play with it but does the container transform as you swipe?
Author
@jh3y Nopes, I just replicated what the "<" & ">" buttons do. |
xorozo
approved these changes
Dec 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #90
I've added a new library (react-swipeable) that already has hooks support. I'll add another issue to update this once released.
It simply checks for swipe and redirects.
I've opened the PR to get early feedback, but there are two things i'm still looking at:
- you might have seen that i added a new page utils but i haven't refactored yet (in More) as the tests fail due to mocking not being done as it should. I'm looking into this atm.