chore: drop yarn zero-install - #2
Merged
Merged
Conversation
Stop committing the Yarn offline cache and switch to the shared global cache. The 1,828 zips in .yarn/cache (175MB) are now gitignored, along with the generated .yarn/install-state.gz. Removing compressionLevel: mixed moves the lockfile to Yarn 4's default cacheKey (10 -> 10c0), which rewrites every checksum but changes no resolutions. CI now caches dependencies via actions/setup-node and installs with --immutable so lockfile drift fails the build.
The Node.js proto plugin is resolved unpinned from the registry at container build time, and now requires proto >= 0.60.0-alpha.0. The build env pinned 0.58.1, so 'proto use' failed. Also corrects the stale comment, which still referenced 0.35.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the repo off Yarn zero-install. The offline cache is no longer committed; Yarn now uses the shared global cache and CI restores dependencies via
actions/setup-node.Also includes a drive-by fix to the Dagger build env, which was broken independently of this change (see below).
Changes
Dropping zero-install (
1084e13).gitignore— removed the!.yarn/cacheexception, so the cache is ignored.patches/plugins/releases/sdks/versionsstay tracked..yarnrc.yml—enableGlobalCache: true, removedcompressionLevel: mixed..yarn/cache(1,828 zips, 175MB) and the generated.yarn/install-state.gz, which had been force-added despite matching.yarn/*.yarn.lock— droppingcompressionLevel: mixedmoves the lockfile to Yarn 4's default cacheKey (10→10c0), rehashing all 1,820 checksums. No resolution or version changed.cache: yarntoactions/setup-nodeand hardened installs toyarn install --immutableso lockfile drift fails the build.Unrelated CI fix (
61bd2bb)workflow_runtime.go:25pinned proto to0.58.1, but the Node.js proto plugin is resolved unpinned from the registry at container build time and has since published a release requiring>= 0.60.0-alpha.0.proto usetherefore failed on any run, regardless of this PR. Bumped to0.60.2(latest stable) in both the real build env and the skeleton template, and corrected the stale comment that still said0.35.3.Verification
rm -rf node_modules && yarn installsucceeded locally from an empty cache.yarn install --immutablethen passed with a clean working tree.cache: yarn+yarn install --immutableon each.Notes for reviewers
.gitignore,.yarnrc.yml, the workflows, and the proto pin.yarn install— packages repopulate from the registry once, into the global cache.yarn.lock-keyed cache.