Add new module managing keycloak role by ndclt · Pull Request #2 · ndclt/ansible

ndclt · 2019-03-01T16:10:42Z

SUMMARY

This module (keycloak_user) allows the use of the Keycloak REST API (http://www.keycloak.org/docs-api/3.4/rest-api/index.html) to administrate Keycloak (http://www.keycloak.org) user.

Keycloak is an Open Source Identity and Access Management system spearheaded by Red Hat. It provides OpenID Connect and SAML authentication/authorization services.

Two prior modules in this namespace have been merged (keycloak_client in 31716 and keycloak_clienttemplate in 33419). This module reuses code introduced therein (from module_utils/keycloak.py).
Four other modules currently have new module PRs pending (keycloak_group in 35637 by adamgoossens, keycloak_scope in 35558 by eikef, keycloak_realms in 35844 and keycloak_user in 52327 by myself); they extend module_utils/keycloak.py as well, though it's all strictly additions.

ISSUE TYPE

New Module Pull Request

COMPONENT NAME

keycloak_role

achaussier · 2019-03-08T09:06:50Z

            self.module.fail_json(msg='Could not delete client template %s in realm %s: %s'
                                      % (id, realm, str(e)))
+
+    def get_role_url(self, role_id, realm='master', client_uuid=None):


Missing docstring

achaussier · 2019-03-27T09:16:48Z

+        else:
+            return None
+
+    def get_json_from_url(self, url):


Missing docstring

achaussier · 2019-03-27T15:02:55Z

+            deleting_role(kc, result, realm, given_role_id, client_uuid)
+
+
+def attributes_format_is_correct(given_attributes):


Missing docstring

achaussier · 2019-03-27T15:03:03Z

+    return True
+
+
+def attribute_as_list_format_is_correct(one_value, first_call=True):


Missing docstring

achaussier · 2019-03-27T15:03:27Z

+    return True
+
+
+def get_initial_role(given_role_id, kc, realm, client_id):


Missing docstring

achaussier · 2019-03-27T15:04:23Z

+    return result
+
+
+def create_changeset(module):


Missing docstring

achaussier · 2019-03-27T15:05:20Z

+    return changeset
+
+
+def do_nothing_and_exit(kc, result, realm, given_role_id, client_id, client_uuid):


Missing docstring

achaussier · 2019-03-27T15:06:29Z

+    module.exit_json(**result)
+
+
+def updating_role(kc, result, realm, given_role_id, client_uuid):


Missing docstring

achaussier · 2019-03-27T15:10:14Z

+    module.exit_json(**result)
+
+
+def put_attributes_values_in_list(attributes_values):


Missing docstring

achaussier · 2019-03-27T15:10:22Z

+    return new_attributes
+
+
+def deleting_role(kc, result, realm, given_role_id, client_uuid):


Missing docstring

…nit test (ansible#55643) * remove external grep call and parse with python * use function for repeated code * use module.get_bin_path() for iscsiutil on HPUX * some code opt for HPUX * clean up non-module code, module being defined is a requirement for this code * import get_bin_path() directly and use without module prefix * Add integration tests for AIX and HP-UX * add changelog fragment * Apply suggestions from code review Co-Authored-By: mator <matorola@gmail.com> * Apply suggestions from code review #2 Co-Authored-By: Sam Doran <sdoran@redhat.com> * Remove strict requirement on executable to exist for get_bin_path() as it will allow facts gathering to continue without an error. Almost all other files under facts do not have "required=True" (except 2 files, which should be probably fixed). And check return value for get_bin_path() , before run attempt. * add check for AIX lsattr run_command return code

…ble#54260) * nxos_interfaces_ospf: fix passive-interface states & check_mode This fix addresses issues ansible#41704 and ansible#45343. The crux of the problem is that `passive-interface` should have been treated as a tri-state value instead of a boolean. The `no` form of the command disables the passive state on an interface (allows it to form adjacencies and send routing updates). It's essentially an override for `passive-interface default` which enables passive state on all OSPF interfaces.\* This `no` config will be present in `running-config`. \**See `router ospf` configuration.* Since both enable and disable states are explicit configs, the proper way to remove either of these is with the `default` syntax. Passive-interface config syntax: ``` ip ospf passive-interface # enable (nvgens) no ip ospf passive-interface # disable (nvgens) default ip ospf passive-interface # default (removes config, does not nvgen) ``` Code changes: * `passive_interface` param changed from boolean to string, restricted to `true`,`false`,`default`. * Several passive-interface specific checks were added because the existing module logic tends to test for true or false and doesn't handle the None case. * Fixed `check_mode`. Sanity verified on: N9K,N7K,N3K,N6K * Fix doc header * Unit tests for passive-interface * doc fix #2 * Fix indent for SA * Remove 'default' keyword, restore bool behavior * remove changes to sanity (cherry picked from commit 20fb77c)

This module allows to create, update and delete roles

This test should not raise an error as before

ndclt force-pushed the keycloak_role branch from 919a4a8 to 44d0e44 Compare March 2, 2019 13:35

achaussier reviewed Mar 28, 2019

View reviewed changes

ndclt closed this in 20fb77c Apr 18, 2019

ndclt reopened this Apr 18, 2019

ndclt force-pushed the keycloak_role branch from 913bb1f to e767c17 Compare May 15, 2019 14:22

ndclt added 3 commits February 18, 2020 11:42

Add new module managing keycloak role

2839736

This module allows to create, update and delete roles

test: add role already in client

fbdbcfa

This test should not raise an error as before

dev: manage role in client edge case

ead3a31

ndclt force-pushed the keycloak_role branch from 7cf8be3 to ead3a31 Compare February 18, 2020 10:46

refactor: use the get_token function

04962f8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new module managing keycloak role#2

Add new module managing keycloak role#2
ndclt wants to merge 4 commits into
develfrom
keycloak_role

ndclt commented Mar 1, 2019

Uh oh!

achaussier Mar 8, 2019

Uh oh!

achaussier Mar 27, 2019

Uh oh!

achaussier Mar 27, 2019

Uh oh!

achaussier Mar 27, 2019

Uh oh!

achaussier Mar 27, 2019

Uh oh!

achaussier Mar 27, 2019

Uh oh!

achaussier Mar 27, 2019

Uh oh!

achaussier Mar 27, 2019

Uh oh!

achaussier Mar 27, 2019

Uh oh!

achaussier Mar 27, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		deleting_role(kc, result, realm, given_role_id, client_uuid)


		def attributes_format_is_correct(given_attributes):

		return True


		def attribute_as_list_format_is_correct(one_value, first_call=True):

		return True


		def get_initial_role(given_role_id, kc, realm, client_id):

		return changeset


		def do_nothing_and_exit(kc, result, realm, given_role_id, client_id, client_uuid):

		module.exit_json(**result)


		def updating_role(kc, result, realm, given_role_id, client_uuid):

		module.exit_json(**result)


		def put_attributes_values_in_list(attributes_values):

		return new_attributes


		def deleting_role(kc, result, realm, given_role_id, client_uuid):

Conversation

ndclt commented Mar 1, 2019

SUMMARY

ISSUE TYPE

COMPONENT NAME

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants