Skip to content

fix(createSSURGO) connection names, file matching, and append/overwrite table logic #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brownag merged 3 commits into from
Sep 8, 2026
Merged

fix(createSSURGO) connection names, file matching, and append/overwrite table logic #485

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d95574b
fix(createSSURGO): more consistent extraction of dbname across DBI co…
AndrewBrown-USDA Sep 6, 2026
7ad7dde
fix(createSSURGO): regex logic for customized spatial subset
AndrewBrown-USDA Sep 6, 2026
ea30500
fix(createSSURGO): edge case in overwrite/append logic
AndrewBrown-USDA Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions R/createSSURGO.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,13 +276,15 @@ createSSURGO <- function(filename = NULL,
}
}

# extract database name from DBIConnection (all types)
if (inherits(conn, 'DBIConnection')) {
filename <- DBI::dbGetInfo(conn)$dbname
}

# DuckDB has special spatial format, so it gets custom handling for
IS_DUCKDB <- inherits(conn, "duckdb_connection")

if (inherits(conn, 'SQLiteConnection')) {
IS_GPKG <- grepl("\\.gpkg$", conn@dbname, ignore.case = TRUE)[1]
filename <- conn@dbname
} else {
if (!inherits(conn, 'SQLiteConnection')) {
IS_GPKG <- grepl("\\.gpkg$", filename, ignore.case = TRUE)[1]
if (is.na(IS_GPKG)) {
IS_GPKG <- FALSE
Expand All @@ -307,7 +309,7 @@ createSSURGO <- function(filename = NULL,
ifelse(is.null(pattern), "*", pattern), "...")

message(
" Output: ", ifelse(is.null(conn), filename, conn@dbname), "\n",
" Output: ", filename, "\n",
" Spatial: ", paste0(include_spatial, collapse = ", "), "\n",
" Tabular: ", paste0(include_tabular, collapse = ", ")
)
Expand Down Expand Up @@ -559,9 +561,12 @@ createSSURGO <- function(filename = NULL,
} else if (isTRUE(append)) {
append_arg <- TRUE
overwrite_arg <- FALSE
} else {
} else if (isTRUE(overwrite)) {
append_arg <- FALSE
overwrite_arg <- overwrite
overwrite_arg <- TRUE
} else {
append_arg <- TRUE
overwrite_arg <- FALSE
}

rec <- .write_table_with_log(
Expand Down Expand Up @@ -687,10 +692,12 @@ createSSURGO <- function(filename = NULL,
idx <- paste0(shp.grp[, 1], "_", shp.grp[, 2]) %in% names(layer_names[layer_names %in% include_spatial])
shp.grp <- shp.grp[idx, , drop = FALSE]
f.shp <- f.shp[idx]
f.shp.sc <- files[grepl(paste0(
paste0("soil", shp.grp[, 1], "_", shp.grp[, 2], "_", shp.grp[, 3]),
collapse = "|"
), files)]
prefixes <- unique(paste0("soil", shp.grp[, 1], "_", shp.grp[, 2], "_"))
if (length(prefixes) > 0) {
f.shp.sc <- files[grepl(paste0("^(", paste(prefixes, collapse = "|"), ")"), basename(files))]
} else {
f.shp.sc <- character(0)
}
include_spatial <- TRUE
}

Expand Down