Repository navigation
Conversation
…, dialogs, book detail and touch targets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of snapetech-org/seerrng#637
A review pass over
lumen/srcplus a phone-width pass (360 and 390 wide). Each fix is its own commit with a release-note fragment; nothing outsidelumen/andrelease-notes/changes.Bugs
TvDetailreset the ticked seasons whenever the show object changed, which a background revalidation does about a second after opening a cached show. Ticks now reset only when the show id or its defaults change.dropCachethenreload, losing scroll position and picked options. NewuseApi.refresh()keeps the page on screen while it refetches.usePagedsnapshot was never revalidated. Snapshots now carry a cache generation and a stale one is re-read quietly./auth/mefailure cleared the user. Only 401/403 does now; anything else shows a Retry screen.document.hiddenand resumes onvisibilitychange./audiobooksis titled "Audiobooks"; book cards have one tab stop;lumen-config.jsonis fetched once per page load.Book detail and requests
Coverfallback when a poster is missing.ConfirmSheet). Remove no longer uses a timed second tap on the same button.Accessibility and touch
useDialoghook for the sheets that setaria-modal: focus moves in, Tab stays inside, Escape closes, the page behind is inert and does not scroll, focus returns to the opener.friendlyError()gives plain messages for network, timeout, 401/403/429 and 5xx errors, keeps sentences the server wrote, and logs the raw error to the console..btn-sm, request-row buttons and Open links are at least 44px high under@media (pointer: coarse), as are the hero buttons, "See all", the avatar, the detail Back button and the sort select. Desktop is unchanged.prefers-reduced-motion.Testing
tsc --noEmitandvite buildclean; node unit tests 35 passed.lumen/tests/browser/audit-fixes.spec.tsand the book detail, dialog, confirmation, drawn cover and touch target cases, plus unit tests for the 4K link and the cache. Two existing tests that clicked Decline and Cancel directly now go through the confirmation.Not included
/settings/publicand/auth/mecalls on page load./me/lumen.