Repository navigation
Conversation
…les open the page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of snapetech-org/seerrng#632.
Two small Lumen card fixes reported by a household user.
Missing art. A movie, series, book or audiobook without art (or whose image fails to load) showed an empty grey box. Cards now draw a cover instead: a colour derived from the title, the title in a serif face, the author or year, and a small format icon. The words come from CSS
attr()on data attributes, so screen readers and text searches still see the title once. Images that fail to load switch to the drawn cover viaonError.Title links. Clicking the title under a card did nothing; only the art opened the page. The title is now a link to the same page. It is pointer-only (
tabIndex=-1,aria-hidden), so the art link stays the single keyboard and screen-reader target and existing role queries are unchanged.Tests
New browser test: a book without art and one with a broken image both get the drawn cover, and clicking the title opens the book. Lumen browser suite: 655 passed, 13 existing viewport skips.