Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of snapetech-org/seerrng#631.
Lumen's audiobook search only asks
/discover/books?format=audiobook, which searches the Chaptarr audiobook catalogue, so it can only find books Chaptarr already has. A new title (e.g. "The Women", Kristin Hannah) returned nothing in the Audiobooks tab even though the Books tab found it through Open Library, and that Open Library work can be requested as an audiobook.When the audiobook search comes back empty, Search now asks the ebook (Open Library) search and shows those works as audiobook cards, so they open on the audiobook page and request the audiobook. Results from the audiobook catalogue still come first; the fallback only runs when it has none.
Tests
New browser test (empty audiobook search shows the Open Library work as an audiobook card linking to
?f=audio). Lumen browser suite on current main: 655 passed, 13 existing viewport skips. Verified on a live install: the Audiobooks tab lists Kristin Hannah's books for "the women kristin hannah", and the book page offers Request audiobook.